[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and conn
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it |
|
Date: |
Thu, 22 Feb 2018 11:46:55 +0000 |
On 16 February 2018 at 02:29, Philippe Mathieu-Daudé <address@hidden> wrote:
> using the sdbus_*() API.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>
> RFC because how pl181_sdbus_create_inplace() doing class_init(SDBus) in
> realize(pl181) seems weird...
In the two other places where we set the set_inserted and set_readonly
methods for the SDBus class (pxa2xx_mmci.c and sdhci.c), we do it by
defining a subclass of TYPE_SD_BUS, whose class init function can then
set up the method pointers. Is there a reason not to do pl181 the
same way as those two examples?
thanks
-- PMM
- [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 1/7] hw/sd/milkymist-memcard: use qemu_log_mask(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 2/7] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init(), Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 3/7] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 4/7] hw/sd/ssi-sd: use the SDBus API, connect the SDCard to the bus, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [RFC PATCH v3 5/7] hw/sd/pl181: expose a SDBus and connect the SDCard to it, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static, Philippe Mathieu-Daudé, 2018/02/15
- [Qemu-devel] [PATCH v3 7/7] hw/sd: move sdcard legacy API to "hw/sd/sdcard_legacy.h", Philippe Mathieu-Daudé, 2018/02/15
- Re: [Qemu-devel] [PATCH v3 0/7] SDHCI: convert legacy devices to the SDBus API (part 6), Peter Maydell, 2018/02/22