Re: [Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source}

[Daniel P . Berrangé]

On Thu, Mar 01, 2018 at 04:44:26PM +0800, Peter Xu wrote:
> Firstly, introduce an internal qio_channel_add_watch_full(), which
> enhances qio_channel_add_watch() that context can be specified.
> 
> Then add a new API wrapper qio_channel_add_watch_source() to return a
> GSource pointer rather than a tag ID.
> 
> Note that the _source() call will keep a reference of GSource so that
> callers need to unref them explicitly when finished using the GSource.
> 
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  include/io/channel.h | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  io/channel.c         | 40 ++++++++++++++++++++++++++++++++++------
>  2 files changed, 78 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|