[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat
From: |
Bastian Koppelmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat |
Date: |
Tue, 27 Mar 2018 11:56:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Hi Emilio,
On 03/27/2018 07:33 AM, Emilio G. Cota wrote:
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg05908.html
>
[...]
>
> Perf numbers are in the last patch. They are a little different than
> last week; I cannot replicate last week's performance (even with
> the very same binaries; might have to reboot the machine I'm using
> soon), but as of today v2 is certainly faster than v1 (e.g. 5% faster
> for nbench-fp).
>
> I have checked all checkpatch warnings; they're all false positives.
>
> You can fetch the series from:
> https://github.com/cota/qemu/tree/hardfloat-v2
When I try to build your tree with gcc version 7.3.1 20180312 (GCC), I get:
CC tricore-softmmu/fpu/softfloat.o
/home/kbastian/coding/upstream-qemu/qemu-fpu/fpu/softfloat.c:417:19:
error: conflicting types for ‘canonicalize’
static FloatParts canonicalize(FloatParts part, const FloatFmt *parm,
^~~~~~~~~~~~
In file included from /usr/include/features.h:423:0,
from /usr/include/bits/libc-header-start.h:33,
from /usr/include/math.h:27,
from
/home/kbastian/coding/upstream-qemu/qemu-fpu/fpu/softfloat.c:85:
/usr/include/bits/mathcalls.h:385:1: note: previous declaration of
‘canonicalize’ was here
__MATHDECL_1 (int, canonicalize,, (_Mdouble_ *__cx, const _Mdouble_ *__x));
Cheers,
Bastian
- [Qemu-devel] [PATCH v2 10/14] hardfloat: support float32/64 division, (continued)
- [Qemu-devel] [PATCH v2 10/14] hardfloat: support float32/64 division, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 14/14] hardfloat: support float32_to_float64, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 07/14] fpu: introduce hardfloat, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 12/14] hardfloat: support float32/64 square root, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 09/14] hardfloat: support float32/64 multiplication, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 11/14] hardfloat: support float32/64 fused multiply-add, Emilio G. Cota, 2018/03/27
- [Qemu-devel] [PATCH v2 02/14] tests: add fp-test, a floating point test suite, Emilio G. Cota, 2018/03/27
- Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat,
Bastian Koppelmann <=
- Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat, Alex Bennée, 2018/03/28
- Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat, no-reply, 2018/03/29
- Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat, no-reply, 2018/03/30