Re: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/14] fp-test + hardfloat

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
acf121ab02 hardfloat: support float32_to_float64
717c53e9e1 hardfloat: support float32/64 comparison
96c01923f0 hardfloat: support float32/64 square root
f2df632dcd hardfloat: support float32/64 fused multiply-add
9ed1261941 hardfloat: support float32/64 division
030055e5dd hardfloat: support float32/64 multiplication
a6ceaae3fd hardfloat: support float32/64 addition and subtraction
85ac349d03 fpu: introduce hardfloat
4661c2c7a8 target/tricore: use float32_is_denormal
bb6b4e9ee9 softfloat: add float{32, 64}_is_{de, }normal
6b0d547870 fp-test: add muladd variants
c56f6dc7d1 softfloat: fix {min, max}nummag for same-abs-value inputs
bfa4c9f682 tests: add fp-test, a floating point test suite
0787c157b4 tests: add fp-bench, a collection of simple floating-point 
microbenchmarks

=== OUTPUT BEGIN ===
Checking PATCH 1/14: tests: add fp-bench, a collection of simple floating-point 
microbenchmarks...
ERROR: braces {} are necessary for all arms of this statement
#158: FILE: tests/fp-bench.c:107:
+    } while (!f32_is_normal(r));
[...]

ERROR: braces {} are necessary for all arms of this statement
#183: FILE: tests/fp-bench.c:132:
+    } while (!f64_is_normal(r));
[...]

ERROR: spaces required around that '*' (ctx:WxV)
#206: FILE: tests/fp-bench.c:155:
+    static void NAME(volatile PRECISION *res)                           \
                                         ^

ERROR: Use of volatile is usually wrong, please add a comment
#206: FILE: tests/fp-bench.c:155:
+    static void NAME(volatile PRECISION *res)                           \

ERROR: Use of volatile is usually wrong, please add a comment
#212: FILE: tests/fp-bench.c:161:
+            volatile PRECISION a;                                       \

ERROR: Use of volatile is usually wrong, please add a comment
#226: FILE: tests/fp-bench.c:175:
+    static void NAME(volatile PRECISION *res)                           \

ERROR: Use of volatile is usually wrong, please add a comment
#233: FILE: tests/fp-bench.c:182:
+            volatile PRECISION a = glue(get_random_, PRECISION)(&ra);   \

ERROR: Use of volatile is usually wrong, please add a comment
#234: FILE: tests/fp-bench.c:183:
+            volatile PRECISION b = glue(get_random_, PRECISION)(&rb);   \

ERROR: Use of volatile is usually wrong, please add a comment
#253: FILE: tests/fp-bench.c:202:
+    static void NAME(volatile PRECISION *res)                           \

ERROR: Use of volatile is usually wrong, please add a comment
#260: FILE: tests/fp-bench.c:209:
+            volatile PRECISION a = glue(get_random_, PRECISION)(&ra);   \

ERROR: Use of volatile is usually wrong, please add a comment
#261: FILE: tests/fp-bench.c:210:
+            volatile PRECISION b = glue(get_random_, PRECISION)(&rb);   \

ERROR: Use of volatile is usually wrong, please add a comment
#274: FILE: tests/fp-bench.c:223:
+    static void NAME(volatile PRECISION *res)                           \

ERROR: Use of volatile is usually wrong, please add a comment
#282: FILE: tests/fp-bench.c:231:
+            volatile PRECISION a = glue(get_random_, PRECISION)(&ra);   \

ERROR: Use of volatile is usually wrong, please add a comment
#283: FILE: tests/fp-bench.c:232:
+            volatile PRECISION b = glue(get_random_, PRECISION)(&rb);   \

ERROR: Use of volatile is usually wrong, please add a comment
#284: FILE: tests/fp-bench.c:233:
+            volatile PRECISION c = glue(get_random_, PRECISION)(&rc);   \

ERROR: braces {} are necessary for all arms of this statement
#359: FILE: tests/fp-bench.c:308:
+    } while (0)
[...]

total: 16 errors, 0 warnings, 356 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/14: tests: add fp-test, a floating point test suite...
ERROR: Macros with complex values should be enclosed in parenthesis
#391: FILE: tests/fp-test/fp-test.c:220:
+#define PR_EXCEPTIONS(x)                                \
+        ((x) & STANDARD_EXCEPTIONS ? "" : "none"),      \
+        (((x) & float_flag_inexact)   ? "x" : ""),      \
+        (((x) & float_flag_underflow) ? "u" : ""),      \
+        (((x) & float_flag_overflow)  ? "o" : ""),      \
+        (((x) & float_flag_divbyzero) ? "z" : ""),      \
+        (((x) & float_flag_invalid)   ? "i" : "")

ERROR: consider using qemu_strtoul in preference to strtoul
#852: FILE: tests/fp-test/fp-test.c:681:
+            significand = strtoul(&p[3], &pos, 16);

ERROR: consider using qemu_strtol in preference to strtol
#857: FILE: tests/fp-test/fp-test.c:686:
+            exponent = strtol(pos, &pos, 10) + 127;

ERROR: consider using qemu_strtoul in preference to strtoul
#882: FILE: tests/fp-test/fp-test.c:711:
+            significand = strtoul(&p[3], &pos, 16);

ERROR: consider using qemu_strtol in preference to strtol
#887: FILE: tests/fp-test/fp-test.c:716:
+            exponent = strtol(pos, &pos, 10) + 1023;

ERROR: consider using qemu_strtof in preference to strtof
#906: FILE: tests/fp-test/fp-test.c:735:
+            float f = strtof(p, &pos);

total: 6 errors, 0 warnings, 1225 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/14: softfloat: fix {min, max}nummag for same-abs-value 
inputs...
Checking PATCH 4/14: fp-test: add muladd variants...
Checking PATCH 5/14: softfloat: add float{32, 64}_is_{de, }normal...
Checking PATCH 6/14: target/tricore: use float32_is_denormal...
Checking PATCH 7/14: fpu: introduce hardfloat...
ERROR: spaces required around that '*' (ctx:WxV)
#90: FILE: fpu/softfloat.c:155:
+    soft_t ## _input_flush__nocheck(soft_t *a, float_status *s)         \
                                                             ^

ERROR: spaces required around that '*' (ctx:WxV)
#100: FILE: fpu/softfloat.c:165:
+    soft_t ## _input_flush1(soft_t *a, float_status *s)                 \
                                                     ^

ERROR: spaces required around that '*' (ctx:WxV)
#109: FILE: fpu/softfloat.c:174:
+    soft_t ## _input_flush2(soft_t *a, soft_t *b, float_status *s)      \
                                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#120: FILE: fpu/softfloat.c:185:
+                            float_status *s)                            \
                                          ^

total: 4 errors, 0 warnings, 103 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/14: hardfloat: support float32/64 addition and subtraction...
Checking PATCH 9/14: hardfloat: support float32/64 multiplication...
Checking PATCH 10/14: hardfloat: support float32/64 division...
Checking PATCH 11/14: hardfloat: support float32/64 fused multiply-add...
Checking PATCH 12/14: hardfloat: support float32/64 square root...
Checking PATCH 13/14: hardfloat: support float32/64 comparison...
ERROR: spaces required around that '*' (ctx:WxV)
#42: FILE: fpu/softfloat.c:2306:
+                             bool is_quiet, float_status *s)            \
                                                          ^

ERROR: spaces required around that '*' (ctx:WxV)
#67: FILE: fpu/softfloat.c:2320:
+float16_compare(float16 a, float16 b, float_status *s)
                                                    ^

total: 2 errors, 0 warnings, 83 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/14: hardfloat: support float32_to_float64...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden