Re: [Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

[Max Filippov]

On Mon, Apr 9, 2018 at 5:23 PM, Richard Henderson
<address@hidden> wrote:
> On 04/06/2018 11:36 AM, Max Filippov wrote:
>> +static void target_to_host_low_high(abi_ulong tlow,
>> +                                    abi_ulong thigh,
>> +                                    unsigned long *hlow,
>> +                                    unsigned long *hhigh)
>> +{
>> +    unsigned long long off = tlow |
>> +        ((unsigned long long)thigh << TARGET_LONG_BITS / 2) <<
>> +        TARGET_LONG_BITS / 2;
>
> Use uint64_t instead of unsigned long long.

Ok.

>> +
>> +    *hlow = (unsigned long)off;
>> +    *hhigh = (unsigned long)((off >> HOST_LONG_BITS / 2) >>
>> +                             HOST_LONG_BITS / 2);
>
> The casts here are unnecessary and are implied by the assignment.

Did that to avoid value truncation warning. Will drop.

> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>

-- 
Thanks.
-- Max