[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x befor
|
From: |
Bastian Koppelmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0 |
|
Date: |
Mon, 16 Apr 2018 16:16:28 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/16/2018 03:54 PM, Alex Bennée wrote:
> The re-factoring of div_floats changed the order of checking meaning
> an operation like -inf/0 erroneously raises the divbyzero flag.
> IEEE-754 (2008) specifies this should only occur for operations on
> finite operands.
>
> We fix this by moving the check on the dividend being Inf/0 to before
> the divisor is zero check.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: Bastian Koppelmann <address@hidden>
> ---
> fpu/softfloat.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Bastian Koppelmann <address@hidden>
Tested-by: Bastian Koppelmann <address@hidden>
Cheers,
Bastian