[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x befor
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0 |
|
Date: |
Mon, 16 Apr 2018 15:42:54 +0100 |
|
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Bastian Koppelmann <address@hidden> writes:
> On 04/16/2018 03:54 PM, Alex Bennée wrote:
>> The re-factoring of div_floats changed the order of checking meaning
>> an operation like -inf/0 erroneously raises the divbyzero flag.
>> IEEE-754 (2008) specifies this should only occur for operations on
>> finite operands.
>>
>> We fix this by moving the check on the dividend being Inf/0 to before
>> the divisor is zero check.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> Cc: Bastian Koppelmann <address@hidden>
>> ---
>> fpu/softfloat.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Reviewed-by: Bastian Koppelmann <address@hidden>
> Tested-by: Bastian Koppelmann <address@hidden>
Peter are you going to grab these tags or do you want me to re-spin?
--
Alex Bennée