[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig stat
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state |
Date: |
Fri, 27 Apr 2018 16:48:45 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/27/2018 10:05 AM, Igor Mammedov wrote:
> Ban it for now, if someone would need it to work early,
> one would have to implement checks if HMP command is valid
> at preconfig state.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
There's a bisection window between when RUN_STATE_PRECONFIG is added and
this patch where HMP can be used to screw things up, but I'm less
worried about that being triggered in practice. If you want to avoid
that window, then introduce RUN_STATE_PRECONFIG in one patch, then this
patch, then add command line --preconfig in a later patch (thus, NOTHING
can get into preconfig state, even though the code is starting to be
modified to honor it, until --preconfig is enabled on the command line).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 06/11] tests: let qapi-schema tests detect allowed-in-preconfig, (continued)
- [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 11/11] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 01/11] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 08/11] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state, Igor Mammedov, 2018/04/27
- Re: [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state,
Eric Blake <=
- [Qemu-devel] [PATCH v6 10/11] qmp: add set-numa-node command, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 09/11] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 02/11] numa: split out NumaOptions parsing into set_numa_options(), Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option, Igor Mammedov, 2018/04/27