Re: [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema

[Eric Blake]

On 04/27/2018 10:05 AM, Igor Mammedov wrote:
> make sure the QAPISchema can parse allowed-in-preconfig correctly
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  tests/Makefile.include                           | 1 +
>  tests/qapi-schema/allowed-in-preconfig-test.err  | 1 +
>  tests/qapi-schema/allowed-in-preconfig-test.exit | 1 +
>  tests/qapi-schema/allowed-in-preconfig-test.json | 2 ++
>  tests/qapi-schema/allowed-in-preconfig-test.out  | 0
>  tests/qapi-schema/qapi-schema-test.json          | 3 +++
>  tests/qapi-schema/qapi-schema-test.out           | 2 ++
>  tests/test-qmp-cmds.c                            | 4 ++++

Aha. I'd squash this with patch 6, since it supplies the additional
tests I was asking about there.  (They were separate on the OOB series
more because of the time crunch of getting it in before rc0; but now
that we aren't under a crunch, I'd rather just have one patch for all
new tests).

>  8 files changed, 14 insertions(+)
>  create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.err
>  create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.exit
>  create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.json
>  create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.out
> 

If you like my bikeshedding for a shorter 'allow-preconfig' name, don't
forget to rename the files as well as their contents.

> +++ b/tests/qapi-schema/qapi-schema-test.json
> @@ -142,6 +142,9 @@
>  # Smoke test on Out-Of-Band
>  { 'command': 'an-oob-command', 'allow-oob': true }
>  
> +# test allowed-in-preconfig flag
> +{ 'command': 'allowed-in-preconfig-test', 'allowed-in-preconfig': true }

Why not just have a single command that sets both allow-oob and
allowed-in-preconfig on the same command?  Of course, rename it to
something other than 'an-oob-command', if you merge things into one command.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature