qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 11/29] target-microblaze: Make compute_ldst_a


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v1 11/29] target-microblaze: Make compute_ldst_addr always use a temp
Date: Thu, 3 May 2018 11:13:41 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/03/2018 02:19 AM, Edgar E. Iglesias wrote:
> -static inline TCGv_i32 *compute_ldst_addr(DisasContext *dc, TCGv_i32 *t)
> +static inline void compute_ldst_addr(DisasContext *dc, TCGv_i32 *t)

You probably also want to remove the indirection,
since you now never assign to *t.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]