[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL poin
From: |
Marcel Apfelbaum |
Subject: |
[Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL pointer |
Date: |
Thu, 3 May 2018 21:21:18 +0300 |
Coverity CID 1390620: we call munmap() on a NULL pointer.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
---
hw/rdma/vmw/pvrdma_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 99019d8741..f9dd78cb27 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req
*req,
cmd->start, cmd->length, host_virt,
cmd->access_flags, &resp->mr_handle,
&resp->lkey, &resp->rkey);
- if (!resp->hdr.err) {
+ if (host_virt && !resp->hdr.err) {
munmap(host_virt, cmd->length);
}
--
2.14.3
- [Qemu-devel] [PULL 0/8] RDMA queue, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 3/8] hw/rdma: Delete port's pkey table, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL pointer,
Marcel Apfelbaum <=
- [Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of a NULL pointer, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 4/8] hw/rdma: Fix possible out of bounds access to GID table, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 5/8] hw/rdma: Fix possible out of bounds access to regs array, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 6/8] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 8/8] MAINTAINERS: update Marcel Apfelbaum email, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 7/8] hw/rdma: Fix possible out of bounds access to port GID index, Marcel Apfelbaum, 2018/05/03
- Re: [Qemu-devel] [PULL 0/8] RDMA queue, Peter Maydell, 2018/05/04