[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of a NULL pointer
From: |
Marcel Apfelbaum |
Subject: |
[Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of a NULL pointer |
Date: |
Thu, 3 May 2018 21:21:19 +0300 |
Coverity CID 1390586; The cq handle is provided by the guest
and cannot be trusted to be previuosly allocated.
Fix it by exiting the completion flow.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Yuval Shaia <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/rdma/vmw/pvrdma_qp_ops.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
index 750ade6c31..99bb51111e 100644
--- a/hw/rdma/vmw/pvrdma_qp_ops.c
+++ b/hw/rdma/vmw/pvrdma_qp_ops.c
@@ -216,6 +216,7 @@ void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t
cq_handle)
cq = rdma_rm_get_cq(dev_res, cq_handle);
if (!cq) {
pr_dbg("Invalid CQ# %d\n", cq_handle);
+ return;
}
rdma_backend_poll_cq(dev_res, &cq->backend_cq);
--
2.14.3
- [Qemu-devel] [PULL 0/8] RDMA queue, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 3/8] hw/rdma: Delete port's pkey table, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL pointer, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of a NULL pointer,
Marcel Apfelbaum <=
- [Qemu-devel] [PULL 4/8] hw/rdma: Fix possible out of bounds access to GID table, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 5/8] hw/rdma: Fix possible out of bounds access to regs array, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 6/8] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 8/8] MAINTAINERS: update Marcel Apfelbaum email, Marcel Apfelbaum, 2018/05/03
- [Qemu-devel] [PULL 7/8] hw/rdma: Fix possible out of bounds access to port GID index, Marcel Apfelbaum, 2018/05/03
- Re: [Qemu-devel] [PULL 0/8] RDMA queue, Peter Maydell, 2018/05/04