Re: [Qemu-devel] [PATCH v2 10/27] fpu/softfloat: re-factor float to float conversions

[Peter Maydell]

On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
> From: Alex Bennée <address@hidden>
>
> This allows us to delete a lot of additional boilerplate code which is
> no longer needed. Currently the ieee flag is ignored (everything is
> assumed to be ieee). Handling for ARM AHP will be in the next patch.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
>
> ---
> v2
>   - pass FloatFmt to float_to_float instead of sizes
>   - split AHP handling to another patch
>   - use rth's suggested re-packing (+ setting .exp)
> v3
>   - also rm extractFloat16Sign
> v4
>   - update for canonical nan handling
> ---
>  fpu/softfloat-specialize.h |  40 ----
>  include/fpu/softfloat.h    |   8 +-
>  fpu/softfloat.c            | 437 ++++++-------------------------------
>  3 files changed, 73 insertions(+), 412 deletions(-)

This is a regression if you put it at this point in the patch series,
because we don't yet have the patches which pass the fp status
and squash FZ16 in the arm helper wrappers before calling the softfloat
code. I think it needs to go after patches 13 and 14.

thanks
-- PMM