[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch |
Date: |
Fri, 8 Jun 2018 19:24:23 +0300 |
On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote:
> On 8 June 2018 at 17:03, Michael S. Tsirkin <address@hidden> wrote:
> > Pull requests are somewhat different, they are usually tested for lack
> > of warnings. This change didn't arrive as a result of a pull request
> > maybe that's why it slipped through the cracks. Peter?
> >
> > Maybe we need a "pedantic" flag to fail on any warnings, or just catch
> > output to stderr.
>
> If there's a situation that shouldn't exist in the tree (ie
> a bug), then make check should catch it, and result in a
> failure, not just printing random stuff to stderr. Otherwise
> I'm not going to notice it, whether I'm applying a pull request
> or an individual patch.
>
> thanks
> -- PMM
It's ok if it happens, but it just makes debugging and reviewing
ACPI patches a little bit harder until it's fixed.
--
MST
- Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words, (continued)
- [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Ross Zwisler, 2018/06/07
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/07
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Thomas Huth, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Ross Zwisler, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Peter Maydell, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Peter Maydell, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Thomas Huth, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Thomas Huth, 2018/06/08
[Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check", Ross Zwisler, 2018/06/07
Re: [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check", Thomas Huth, 2018/06/08
[Qemu-devel] [qemu PATCH 5/5] nvdimm: make persistence option symbolic, Ross Zwisler, 2018/06/07