qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID featu


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit
Date: Wed, 13 Jun 2018 13:56:20 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Wed, Jun 13, 2018 at 05:39:50PM +0100, Daniel P. Berrangé wrote:
[...]
> > The code that finds the AMD_SSBD and sets the 'ssbd' is:
> > 
> > +       if (cpu_has(c, X86_FEATURE_AMD_SSBD)) {
> > +               set_cpu_cap(c, X86_FEATURE_SSBD);
> > +               set_cpu_cap(c, X86_FEATURE_MSR_SPEC_CTRL);
> > +               clear_cpu_cap(c, X86_FEATURE_VIRT_SSBD);
> > +       }
> > 
> > Meaning the 'ssbd' will show up in /proc/cpuinfo
> 
> Given that, there's no exposed kernel naming we need to align with.
> 
> So personally I'd be fine with the current patches that exist, but
> I'll defer to Eduardo for the final say, wrt amd-ssb-no vs amd-no-ssb.

I prefer amd-no-ssb, so I plan to apply these patches as is.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]