[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] (no subject)
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] (no subject) |
Date: |
Tue, 26 Jun 2018 19:21:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
I fooled around a bit, and I think there are a few lose ends.
Lets update the examples in docs/interop/qmp-spec.txt to show the
current greeting (section 3.1) and how to accept a capability (section
3.2). The capability negotiation documentation could use some polish.
I'll post a patch.
Talking to a QMP monitor that supports OOB:
$ socat UNIX:test-qmp READLINE,history=$HOME/.qmp_history,prompt='QMP> '
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 12, "major": 2},
"package": "v2.12.0-1703-gb909799463"}, "capabilities": ["oob"]}}
QMP> { "execute": "qmp_capabilities", "arguments": { "oob": true } }
{"error": {"class": "GenericError", "desc": "Parameter 'oob' is
unexpected"}}
QMP> { "execute": "qmp_capabilities", "arguments": { "enable": ["oob"] } }
{"return": {}}
QMP> { "execute": "query-qmp-schema" }
{"error": {"class": "GenericError", "desc": "Out-Of-Band capability
requires that every command contains an 'id' field"}}
Why does every command require 'id'?
Talking to a QMP monitor that doesn't support OOB:
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 12, "major": 2},
"package": "v2.12.0-1703-gb909799463"}, "capabilities": []}}
QMP> { "execute": "qmp_capabilities", "arguments": { "enable": ["oob"] } }
{"error": {"class": "GenericError", "desc": "This monitor does not support
Out-Of-Band (OOB)"}}
QMP> { "execute": "qmp_capabilities" }
{"return": {}}
QMP> { "execute": "query-kvm" }
{"return": {"enabled": true, "present": true}}
QMP> { "execute": "query-kvm", "control": { "run-oob": true } }
{"error": {"class": "GenericError", "desc": "Please enable Out-Of-Band
first for the session during capabilities negotiation"}}
Telling people to enable OOB when that cannot be done is suboptimal.
More so when it cannot be used here anyway. I'll post a patch.
- [Qemu-devel] [PATCH v5 2/7] monitor: rename *_pop_one to *_pop_any, (continued)
- [Qemu-devel] [PATCH v5 4/7] tests: iotests: drop some stderr line, Peter Xu, 2018/06/20
- [Qemu-devel] [PATCH v5 5/7] docs: mention shared state protect for OOB, Peter Xu, 2018/06/20
- [Qemu-devel] [PATCH v5 6/7] monitor: remove "x-oob", turn oob on by default, Peter Xu, 2018/06/20
- [Qemu-devel] [PATCH v5 7/7] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Peter Xu, 2018/06/20
- [Qemu-devel] (no subject),
Markus Armbruster <=
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Daniel P . Berrangé, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Peter Xu, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Eric Blake, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/28
- Re: [Qemu-devel] monitor: enable OOB by default, Peter Xu, 2018/06/29
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/28
- Re: [Qemu-devel] monitor: enable OOB by default, Eric Blake, 2018/06/28