[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] target/arm: Prune a57 features from max
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] target/arm: Prune a57 features from max |
|
Date: |
Thu, 28 Jun 2018 21:38:50 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 09:15 PM, Richard Henderson wrote:
> There is no need to re-set these 9 features already
> implied by the call to aarch64_a57_initfn.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/arm/cpu64.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
> index 3b4bc73ffa..8040493d5c 100644
> --- a/target/arm/cpu64.c
> +++ b/target/arm/cpu64.c
> @@ -235,19 +235,10 @@ static void aarch64_max_initfn(Object *obj)
> * whereas the architecture requires them to be present in both if
> * present in either.
> */
> - set_feature(&cpu->env, ARM_FEATURE_V8);
> - set_feature(&cpu->env, ARM_FEATURE_VFP4);
> - set_feature(&cpu->env, ARM_FEATURE_NEON);
> - set_feature(&cpu->env, ARM_FEATURE_AARCH64);
> - set_feature(&cpu->env, ARM_FEATURE_V8_AES);
> - set_feature(&cpu->env, ARM_FEATURE_V8_SHA1);
> - set_feature(&cpu->env, ARM_FEATURE_V8_SHA256);
> set_feature(&cpu->env, ARM_FEATURE_V8_SHA512);
> set_feature(&cpu->env, ARM_FEATURE_V8_SHA3);
> set_feature(&cpu->env, ARM_FEATURE_V8_SM3);
> set_feature(&cpu->env, ARM_FEATURE_V8_SM4);
> - set_feature(&cpu->env, ARM_FEATURE_V8_PMULL);
> - set_feature(&cpu->env, ARM_FEATURE_CRC);
> set_feature(&cpu->env, ARM_FEATURE_V8_ATOMICS);
> set_feature(&cpu->env, ARM_FEATURE_V8_RDM);
> set_feature(&cpu->env, ARM_FEATURE_V8_DOTPROD);
>