Re: [Qemu-devel] [PATCH v3 10/10] migration: show the statistics of compression

[Xiao Guangrong]

On 08/08/2018 02:12 PM, Peter Xu wrote:
> On Tue, Aug 07, 2018 at 05:12:09PM +0800, address@hidden wrote:
>
> [...]
>
> > @@ -1602,6 +1614,26 @@ static void migration_update_rates(RAMState *rs, int64_t 
> > end_time)
> >               rs->xbzrle_cache_miss_prev) / page_count;
> >           rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss;
> >       }
> > +
> > +    if (migrate_use_compression()) {
> > +        compression_counters.busy_rate = (double)(compression_counters.busy -
> > +            rs->compress_thread_busy_prev) / page_count;
>
> So this is related to the previous patch - I still doubt its
> correctness if page_count is the host pages count rather than the
> guest pages'.  Other than that the patch looks good to me.

I think i can treat it as your Reviewed-by boldly. :)