[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/10] migration: show the statistics of comp
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/10] migration: show the statistics of compression |
Date: |
Thu, 9 Aug 2018 11:34:32 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Thu, Aug 09, 2018 at 11:13:17AM +0800, Xiao Guangrong wrote:
>
>
> On 08/08/2018 02:12 PM, Peter Xu wrote:
> > On Tue, Aug 07, 2018 at 05:12:09PM +0800, address@hidden wrote:
> >
> > [...]
> >
> > > @@ -1602,6 +1614,26 @@ static void migration_update_rates(RAMState *rs,
> > > int64_t end_time)
> > > rs->xbzrle_cache_miss_prev) / page_count;
> > > rs->xbzrle_cache_miss_prev = xbzrle_counters.cache_miss;
> > > }
> > > +
> > > + if (migrate_use_compression()) {
> > > + compression_counters.busy_rate =
> > > (double)(compression_counters.busy -
> > > + rs->compress_thread_busy_prev) / page_count;
> >
> > So this is related to the previous patch - I still doubt its
> > correctness if page_count is the host pages count rather than the
> > guest pages'. Other than that the patch looks good to me.
>
> I think i can treat it as your Reviewed-by boldly. :)
Yes, please do. :)
Regards,
--
Peter Xu
- Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly, (continued)
[Qemu-devel] [PATCH v3 09/10] migration: fix calculating xbzrle_counters.cache_miss_rate, guangrong . xiao, 2018/08/07
[Qemu-devel] [PATCH v3 10/10] migration: show the statistics of compression, guangrong . xiao, 2018/08/07