[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node |
Date: |
Fri, 10 Aug 2018 11:52:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/08/2018 11:45, Emanuele wrote:
> On 08/09/2018 04:16 PM, Laurent Vivier wrote:
>> On 06/08/2018 16:34, Emanuele Giuseppe Esposito wrote:
>>> -static void mmio_basic(void)
>>> +static void basic_resize(void *obj, void *data, QGuestAllocator
>>> *t_alloc)
>>> {
>>> - QVirtioMMIODevice *dev;
>>> - QVirtQueue *vq;
>>> - QGuestAllocator *alloc;
>>> + QVirtioBlk *blk_if = obj;
>>> + QVirtioDevice *dev = blk_if->vdev;
>>> int n_size = TEST_IMAGE_SIZE / 2;
>>> uint64_t capacity;
>>> + QVirtQueue *vq;
>>> - arm_test_start();
>>> -
>>> - dev = qvirtio_mmio_device_new(MMIO_DEV_BASE_ADDR, MMIO_PAGE_SIZE);
>> This is the only user of qvirtio_mmio_device_new(), so if you remove the
>> call here, you could also remove the function definition.
> So you suggest to get rid completely of qvirtio_mmio_device_new() in
> virtio-mmio.c ?
Yes.
> Couldn't it be useful in future maybe?
We'll be able to use qvirtio_mmio_init_device() instead, so I don't
think it's a problem.
Thanks,
Laurent
- [Qemu-devel] [PATCH v2 23/34] test/qgraph: virtio-9p test node, (continued)
- [Qemu-devel] [PATCH v2 23/34] test/qgraph: virtio-9p test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 26/34] test/qgraph: virtio-rng driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 27/34] test/qgraph: virtio-rng test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 25/34] test/qgraph: virtio-balloon test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 28/34] test/qgraph: virtio-blk driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 31/34] test/qgraph: virtio-net test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 30/34] test/qgraph: virtio-net driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 29/34] test/qgraph: virtio-blk test node, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 32/34] test/qgraph: virtio-scsi driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 34/34] test/qgraph: temporarly commented vhost-user-test, Emanuele Giuseppe Esposito, 2018/08/06
- [Qemu-devel] [PATCH v2 33/34] test/qgraph: virtio-scsi test node, Emanuele Giuseppe Esposito, 2018/08/06
- Re: [Qemu-devel] [PATCH v2 00/34] Qtest driver framework, Paolo Bonzini, 2018/08/09