|
From: | Emanuele |
Subject: | Re: [Qemu-devel] [PATCH v2 00/34] Qtest driver framework |
Date: | Fri, 10 Aug 2018 12:40:31 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/09/2018 11:44 AM, Paolo Bonzini wrote:
Paolo, did you have a chance to test the fixes? I tried, it seems to be working fine. About valgrind, it only detects an "invalide read of size 8" in blk-hotplug test (tests/virtio-blk-test.c), but I don't know why is it doing this.On 09/08/2018 11:20, Emanuele wrote:Why this? Shouldn't it be: if (g_strcmp0(old_path, path)) { qtest_end(); /* handles global_qtest = NULL */ g_free(old_path); /* handles NULL */ old_path = path; global_qtest = qtest_start(path); } else ....Yes, of course. Though I'd have thought that my version has "just" a memory leak. Even better, this could call qos_invalidate_command_line. Can you post the fixes to a separate commit on github?
For the rest, there shouldn't be any memory leak. Should I rebase them in the proper commits? I am ready to submit patch v3. Emanuele
[Prev in Thread] | Current Thread | [Next in Thread] |