[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/56] qmp-cmd-test: Split off qmp-test
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 04/56] qmp-cmd-test: Split off qmp-test |
Date: |
Fri, 10 Aug 2018 15:49:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> qmp-test is for QMP protocol tests. Commit e4a426e75ef added generic,
>> basic tests of query commands to it. Move them to their own test
>> program qmp-cmd-test, to keep qmp-test focused on the protocol.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> MAINTAINERS | 1 +
>> tests/Makefile.include | 3 +
>> tests/qmp-cmd-test.c | 213 +++++++++++++++++++++++++++++++++++++++++
>> tests/qmp-test.c | 191 +-----------------------------------
>> 4 files changed, 218 insertions(+), 190 deletions(-)
>> create mode 100644 tests/qmp-cmd-test.c
>>
>
>> +++ b/tests/qmp-cmd-test.c
>> @@ -0,0 +1,213 @@
>> +/*
>> + * QMP command test cases
>> + *
>> + * Copyright (c) 2017 Red Hat Inc.
>
> Worth adding 2018?
I'll do that in one of the patches that adds something new.
>> + *
>> + * Authors:
>> + * Markus Armbruster <address@hidden>,
>> + *
>
> Trailing comma is odd. And these days, I'm inclined to omit Author
> lines (git history is more reliable, anyways)
Comma inherited from qmp-test.c. I'm fixing both.
> Those are minor issues, where it is up to you if/how to clean them, so
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 13/56] check-qjson: Fix utf8_string() to test all invalid sequences, (continued)
- [Qemu-devel] [PATCH 10/56] check-qjson: Drop redundant string tests, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 04/56] qmp-cmd-test: Split off qmp-test, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 39/56] json: Leave rejecting invalid interpolation to parser, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 46/56] json: Assert json_parser_parse() consumes all tokens on success, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 49/56] json: Streamline json_message_process_token(), Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 56/56] docs/interop/qmp-spec: How to force known good parser state, Markus Armbruster, 2018/08/08