[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/56] check-qjson: Drop redundant string tests
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 10/56] check-qjson: Drop redundant string tests |
Date: |
Wed, 8 Aug 2018 14:02:48 +0200 |
simple_string() and single_quote_string() add nothing to
escaped_string() anymore. Drop them.
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/check-qjson.c | 59 ---------------------------------------------
1 file changed, 59 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index e899e2d361..f0e8967a53 100644
--- a/tests/check-qjson.c
+++ b/tests/check-qjson.c
@@ -117,63 +117,6 @@ static void escaped_string(void)
}
}
-static void simple_string(void)
-{
- int i;
- struct {
- const char *encoded;
- const char *decoded;
- } test_cases[] = {
- { "\"hello world\"", "hello world" },
- { "\"the quick brown fox jumped over the fence\"",
- "the quick brown fox jumped over the fence" },
- {}
- };
-
- for (i = 0; test_cases[i].encoded; i++) {
- QObject *obj;
- QString *str;
-
- obj = qobject_from_json(test_cases[i].encoded, &error_abort);
- str = qobject_to(QString, obj);
- g_assert(str);
- g_assert(strcmp(qstring_get_str(str), test_cases[i].decoded) == 0);
-
- str = qobject_to_json(obj);
- g_assert(strcmp(qstring_get_str(str), test_cases[i].encoded) == 0);
-
- qobject_unref(obj);
-
- qobject_unref(str);
- }
-}
-
-static void single_quote_string(void)
-{
- int i;
- struct {
- const char *encoded;
- const char *decoded;
- } test_cases[] = {
- { "'hello world'", "hello world" },
- { "'the quick brown fox \\' jumped over the fence'",
- "the quick brown fox ' jumped over the fence" },
- {}
- };
-
- for (i = 0; test_cases[i].encoded; i++) {
- QObject *obj;
- QString *str;
-
- obj = qobject_from_json(test_cases[i].encoded, &error_abort);
- str = qobject_to(QString, obj);
- g_assert(str);
- g_assert(strcmp(qstring_get_str(str), test_cases[i].decoded) == 0);
-
- qobject_unref(str);
- }
-}
-
static void utf8_string(void)
{
/*
@@ -1512,10 +1455,8 @@ int main(int argc, char **argv)
{
g_test_init(&argc, &argv, NULL);
- g_test_add_func("/literals/string/simple", simple_string);
g_test_add_func("/literals/string/escaped", escaped_string);
g_test_add_func("/literals/string/utf8", utf8_string);
- g_test_add_func("/literals/string/single_quote", single_quote_string);
g_test_add_func("/literals/string/vararg", vararg_string);
g_test_add_func("/literals/number/simple", simple_number);
--
2.17.1
- Re: [Qemu-devel] [PATCH 53/56] json: Make JSONToken opaque outside json-parser.c, (continued)
- [Qemu-devel] [PATCH 10/56] check-qjson: Drop redundant string tests,
Markus Armbruster <=
- [Qemu-devel] [PATCH 04/56] qmp-cmd-test: Split off qmp-test, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 39/56] json: Leave rejecting invalid interpolation to parser, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 46/56] json: Assert json_parser_parse() consumes all tokens on success, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 49/56] json: Streamline json_message_process_token(), Markus Armbruster, 2018/08/08