Re: [Qemu-devel] [PATCH 18/56] json: Revamp lexer documentation

[Eric Blake]

On 08/10/2018 09:31 AM, Markus Armbruster wrote:

> > > + *
> > > + * [Numbers:]
> >
> > Worth also calling out:
> >
> > [Objects:]
> >        object = begin-object [ member *( value-separator member ) ]
> >                 end-object
> >
> >        member = string name-separator value
> > [Arrays:]
> >     array = begin-array [ value *( value-separator value ) ] end-array
> >
> > so as to completely cover the RFC grammar?
>
> Should this go into json-parser.c?

Perhaps. After all, the lexer does nothing special for any of those 
constructs; they are where we really have moved into the parser phase.


> > > + * - Interpolation:
> > > + *   interpolation = %((l|ll|I64)[du]|[ipsf])
> >
> > Not in your series, but we recently discussed adding %% (only inside
> > strings); coupled with enforcing that all other interpolation occurs
> > outside of strings.  I guess we can update this comment at that time.
>
> Message-ID: <address@hidden>
> https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg05844.html
>
> I meant to do that in this series, but got overwhelmed by all the other
> stuff, and forgot.  Thanks for the reminder.  I may still do it in v2.
> If not, we can do it on top.

Here's where I first attempted it, if it helps.

https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg00603.html

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org