[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 51/56] json: Eliminate lexer state IN_ERROR and
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 51/56] json: Eliminate lexer state IN_ERROR and pseudo-token JSON_MIN |
Date: |
Thu, 16 Aug 2018 17:48:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> include/qapi/qmp/json-lexer.h | 10 ++++------
>> qobject/json-lexer.c | 18 ++++++++----------
>> 2 files changed, 12 insertions(+), 16 deletions(-)
>>
>
>> @@ -335,8 +334,7 @@ static void json_lexer_feed_char(JSONLexer *lexer, char
>> ch, bool flush)
>> json_message_process_token(lexer, lexer->token, JSON_ERROR,
>> lexer->x, lexer->y);
>> g_string_truncate(lexer->token, 0);
>> - new_state = lexer->start_state;
>> - lexer->state = new_state;
>> + lexer->state = lexer->start_state;
>
> Does this simplification belong in an earlier patch?
Hmm, PATCH 37 would be a better fit indeed.
> Otherwise,
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 43/56] qjson: Fix qobject_from_json() & friends for multiple values, (continued)
- [Qemu-devel] [PATCH 43/56] qjson: Fix qobject_from_json() & friends for multiple values, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 12/56] check-qjson: Simplify utf8_string(), Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 54/56] qobject: Drop superfluous includes of qemu-common.h, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 53/56] json: Make JSONToken opaque outside json-parser.c, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 51/56] json: Eliminate lexer state IN_ERROR and pseudo-token JSON_MIN, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 13/56] check-qjson: Fix utf8_string() to test all invalid sequences, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 41/56] json: Nicer recovery from invalid leading zero, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 10/56] check-qjson: Drop redundant string tests, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 04/56] qmp-cmd-test: Split off qmp-test, Markus Armbruster, 2018/08/08