Re: [Qemu-devel] [PATCH 06/35] exec: use cpu_reset_interrupt

[Richard Henderson]

On 9/17/18 9:30 AM, Emilio G. Cota wrote:
> From: Paolo Bonzini <address@hidden>
> 
> It will be changed to an atomic operation soon.
> 
> Cc: Peter Crosthwaite <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  accel/tcg/cpu-exec.c | 6 +++---

Reviewed-by: Richard Henderson <address@hidden>

> diff --git a/exec.c b/exec.c
> index 6826c8337d..0b8e2420cf 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -776,7 +776,7 @@ static int cpu_common_post_load(void *opaque, int 
> version_id)
>  
>      /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the
>         version_id is increased. */
> -    cpu->interrupt_request &= ~0x01;
> +    cpu_reset_interrupt(cpu, 0x01);

I guess this doesn't hurt, although it's irrelevant.
We're in the middle of loadvm and there will not be
concurrent modification.


r~