[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure |
Date: |
Mon, 1 Oct 2018 10:18:45 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Sep 27, 2018 at 04:33:16PM +0200, Markus Armbruster wrote:
> Igor Mammedov <address@hidden> writes:
>
> > On Tue, 25 Sep 2018 18:02:48 +0200
> > Kashyap Chamarthy <address@hidden> wrote:
[...]
> >> +(3) Check which socket is free to allow hotplugging a CPU::
> > may be: which cpus are possible to plug (an entry with qom-path
> > property describes an existing cpu)
>
> Suggest
>
> (3) Find out which CPU types could be plugged, and into which sockets:
Yeah, clearer.
[...]
> >> +(4) We can see that socket 1 is free,
>
> How? I know, but only because I just read the documentation of
> query-hotpluggable-cpus. Which by the way sucks. For instance, will
> the command always return exactly one HotpluggableCPU object per socket?
About the 'how', I was not entirely sure, hence my request in the cover
letter.
> Anyway, what about this:
>
> The command returns an object with a "qom-path" member for each
> present CPU. In this case, it shows an IvyBridge-IBRS-x86_64-cpu in
> socket 0.
>
> It returns an object without a "qom-path" for every possibly CPU
> hot-plug. In this case, it shows you can plug an
> IvyBridge-IBRS-x86_64-cpu into socket 1, and the additional
> properties you need to pass to device_add for that.
Crystal clear.
Many thanks for the review!
> > ... and 'arguments' provide a list of property/value pairs to create
> > corresponding cpu.
> >
> >> + "IvyBridge-IBRS-x86_64-cpu"::
>
> Suggest
>
> (4) Hot-plug an additional CPU:
[...]
--
/kashyap
- Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure,
Kashyap Chamarthy <=