Re: [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure

[Eric Blake]

On 10/1/18 3:59 AM, Igor Mammedov wrote:

> > > Anyway, what about this:
> > >
> > >      The command returns an object with a "qom-path" member for each
> > >      present CPU.  In this case, it shows an IvyBridge-IBRS-x86_64-cpu in
> > >      socket 0.
> > >
> > >      It returns an object without a "qom-path" for every possibly CPU
> > >      hot-plug.  In this case, it shows you can plug an
> > >      IvyBridge-IBRS-x86_64-cpu into socket 1, and the additional
> > >      properties you need to pass to device_add for that.
> not really sure my English (CCed Eric) but to match 'an object' with
> the rest of sentence:
>
>   It returns an object without a "qom-path" for a possible to hot-plug CPU.
>   +
>   In this case, it shows you can plug an  IvyBridge-IBRS-x86_64-cpu
>   into socket 1/core = 0/thread 0, where 'props' list describes
>   additional properties you need to pass to device_add for hot-pluging
>   that CPU.

Maybe:

The command returns an object for CPUs that are present (containing a 
"qom-path" member) or which may be hot-plugged (no "qom-path" member). 
In this example, an IvyBridge-IBRS-x86_64-cpu is present in socket 0, 
while hot-plugging a CPU into socket 1 requires passing the listed 
properties to device_add.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org