|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 10/28] target/riscv: Convert RV32F insns to decodetree |
| Date: | Sat, 13 Oct 2018 10:33:40 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> +#define REQUIRE_FPU \
> +if (!(ctx->flags & TB_FLAGS_FP_ENABLE)) \
> + gen_exception_illegal(ctx)
Should wrap this in do { } while (0). And simply return true after the
exception; no need to generate the dead code that follows.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |