[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns t
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree |
|
Date: |
Fri, 12 Oct 2018 11:18:42 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/12/18 10:30 AM, Bastian Koppelmann wrote:
> +static bool trans_jal(DisasContext *ctx, arg_jal *a, uint32_t insn)
> +{
> + CPURISCVState *env = current_cpu->env_ptr;
> + gen_jal(env, ctx, a->rd, a->imm);
I think you should go ahead and put env into ctx, which is probably where it
should have been in the first place for gen_jal et al to examine features.
Reading from current_cpu is definitely suspect.
r~
- Re: [Qemu-devel] [PATCH 04/28] target/riscv: Convert RVXI arithmetic insns to decodetree, (continued)
- [Qemu-devel] [PATCH 01/28] targer/riscv: Activate decodetree and implemnt LUI & AUIPC, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 07/28] target/riscv: Convert RVXM insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 06/28] target/riscv: Convert RVXI csr insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 05/28] target/riscv: Convert RVXI fence insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree, Bastian Koppelmann, 2018/10/12
- Re: [Qemu-devel] [PATCH 02/28] target/riscv: Convert RVXI branch insns to decodetree,
Richard Henderson <=
- [Qemu-devel] [PATCH 08/28] target/riscv: Convert RV32A insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 11/28] target/riscv: Convert RV64F insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 10/28] target/riscv: Convert RV32F insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 14/28] target/riscv: Convert RV priv insns to decodetree, Bastian Koppelmann, 2018/10/12
- [Qemu-devel] [PATCH 18/28] target/riscv: Remove gen_jalr(), Bastian Koppelmann, 2018/10/12