|
| From: | Eric Blake |
| Subject: | Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event |
| Date: | Wed, 17 Oct 2018 08:51:35 -0500 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/17/18 2:17 AM, Dominik Csapak wrote:
On 10/8/18 3:19 PM, Dominik Csapak wrote:when '-no-reboot' is set, it is interesting if the guest was originally shutdown or reset, so save and return that info Signed-off-by: Dominik Csapak <address@hidden> --- qapi/run-state.json | 5 ++++- vl.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 332e44897b..ec1769777d 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -107,6 +107,9 @@# a guest-initiated ACPI shutdown request or other hardware-specific action) # rather than a host request (such as sending qemu a SIGINT). (since 2.10)# +# @was_reset: If true, the shutdown was actually a reset, but no-reboot +# was set, so it got converted to a shutdown
New additions should prefer naming like 'was-reset' rather than 'was_reset', if we still think this particular name is appropriate. My personal take: what does the 'was' add, which would prevent us from just using the name 'reset' and avoiding the separator spelling issue?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |