Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

[Eric Blake]

On 10/17/18 5:58 AM, Paolo Bonzini wrote:

> > -        qapi_event_send_shutdown(shutdown_caused_by_guest(request));
> > +        qapi_event_send_shutdown(shutdown_caused_by_guest(request),
> > +                                 shutdown_was_reset);
>
> So the problem with shutdown_caused_by_guest is that you get the same
> value for both guest reset and guest shutdown.  Could we instead just
> pass the ShutdownCause in the event (similar to what was proposed even
> when discussing commit 08fba7ac9b618516a5f1d096f78a7e2837fe0594)?

Indeed, it sounds like we are now at the point where we want to do 
precisely that - expose more fine-grained details by adding 
ShutdownCause as a QAPI enum, rather than just adding another bool per 
reason.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org