Re: [Qemu-devel] [RFC v3 13/56] lm32: convert to cpu_halted

[Richard Henderson]

On 10/19/18 2:05 AM, Emilio G. Cota wrote:
> Cc: Michael Walle <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/lm32/op_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

+++ b/target/lm32/op_helper.c
> @@ -31,7 +31,7 @@ void HELPER(hlt)(CPULM32State *env)
>  {
>      CPUState *cs = CPU(lm32_env_get_cpu(env));
>  
> -    cs->halted = 1;
> +    cpu_halted_set(cs, 1);
>      cs->exception_index = EXCP_HLT;
>      cpu_loop_exit(cs);

I am beginning to think this sequence of three should be its own helper...


r~