[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 10/56] ppc: convert to cpu_halted
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC v3 10/56] ppc: convert to cpu_halted |
Date: |
Sun, 21 Oct 2018 13:56:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/19/18 2:05 AM, Emilio G. Cota wrote:
> @@ -1088,11 +1088,13 @@ static target_ulong h_cede(PowerPCCPU *cpu,
> sPAPRMachineState *spapr,
>
> env->msr |= (1ULL << MSR_EE);
> hreg_compute_hflags(env);
> + cpu_mutex_lock(cs);
> if (!cpu_has_work(cs)) {
> - cs->halted = 1;
> + cpu_halted_set(cs, 1);
> cs->exception_index = EXCP_HLT;
> cs->exit_request = 1;
> }
> + cpu_mutex_unlock(cs);
> return H_SUCCESS;
Why does this one get extra locking?
r~
- Re: [Qemu-devel] [RFC v3 11/56] sh4: convert to cpu_halted, (continued)
- [Qemu-devel] [RFC v3 05/56] cpu: move run_on_cpu to cpus-common, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 03/56] cpu: introduce cpu_mutex_lock/unlock, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 04/56] cpu: make qemu_work_cond per-cpu, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 06/56] cpu: introduce process_queued_cpu_work_locked, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 02/56] cpu: rename cpu->work_mutex to cpu->lock, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 10/56] ppc: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- Re: [Qemu-devel] [RFC v3 10/56] ppc: convert to cpu_halted,
Richard Henderson <=
- [Qemu-devel] [RFC v3 13/56] lm32: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 01/56] cpu: convert queued work to a QSIMPLEQ, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 08/56] cpu: define cpu_halted helpers, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 09/56] arm: convert to cpu_halted, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 16/56] riscv: convert to cpu_halted, Emilio G. Cota, 2018/10/18