qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] target/arm: Fill in ARMISARegisters for kvm


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 2/5] target/arm: Fill in ARMISARegisters for kvm64
Date: Mon, 29 Oct 2018 16:03:19 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 10/29/18 2:58 PM, Peter Maydell wrote:
> I think I would prefer it if we expanded the id_isar* fields
> in the ARMISARegisters struct to uint64_t. If you dislike
> that, I think we should make this code fail a bit more gracefully
> in the presence of an unexpected extension into the high bits
> of these registers. Or just ignore the high bits, since we're
> effectively trusting that future architecture versions use
> a compatible meaning for these registers anyway.

Given these options, I'd prefer to just ignore the high bits.
I'm fairly comfortable trusting that the architecture gods
won't mess up and assign values in there.  Otherwise they
would have already expanded instead of adding ID_ISAR6.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]