[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_an
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit() |
|
Date: |
Thu, 4 Apr 2019 08:43:27 +0700 |
On Sat, 30 Mar 2019 at 03:09, Zhang Chen <address@hidden> wrote:
>
> From: Zhang Chen <address@hidden>
>
> In current codes we use change_bit() to finish the job.
>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
> include/qemu/bitmap.h | 1 -
> include/qemu/bitops.h | 15 ---------------
> 2 files changed, 16 deletions(-)
Do we gain anything by removing this function? IIRC these functions
are all borrowed from the Linux kernel, so keeping the same API
as the kernel does would make sense to me, even if we happen
not to use all of it right now.
thanks
-- PMM