Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

[Zhang, Chen]

> -----Original Message-----
> From: Peter Maydell [mailto:address@hidden
> Sent: Thursday, April 4, 2019 9:43 AM
> To: Zhang, Chen <address@hidden>
> Cc: Dr. David Alan Gilbert <address@hidden>; qemu-dev <qemu-
> address@hidden>; John Snow <address@hidden>; Fam Zheng
> <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function
> test_and_change_bit()
> 
> On Sat, 30 Mar 2019 at 03:09, Zhang Chen <address@hidden> wrote:
> >
> > From: Zhang Chen <address@hidden>
> >
> > In current codes we use change_bit() to finish the job.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > ---
> >  include/qemu/bitmap.h |  1 -
> >  include/qemu/bitops.h | 15 ---------------
> >  2 files changed, 16 deletions(-)
> 
> Do we gain anything by removing this function? IIRC these functions are all
> borrowed from the Linux kernel, so keeping the same API as the kernel does
> would make sense to me, even if we happen not to use all of it right now.
> 

Hi Peter,

OK, I agree with you.
But another question are the bitmap.h and bitops.h lack of maintenance.
Please look at this patch:
[PATCH] MAINTAINERS: Add unmaintained bitmap file to related field

Do you have any comments?

Thanks
Zhang Chen

> thanks
> -- PMM