Re: [Qemu-devel] [PATCH v2] ui/cocoa: Fix absolute input device grabbing issues on Mojave

[Chen Zhang]

ping

http://patchwork.ozlabs.org/patch/1058186/

> On Mar 28, 2019, at 10:05 AM, Chen Zhang <address@hidden> wrote:
> 
> 
> 
>> On Mar 27, 2019, at 7:37 PM, Peter Maydell <address@hidden> wrote:
>> 
>> On Wed, 27 Mar 2019 at 01:09, Chen Zhang <address@hidden> wrote:
>>> Just double-checked on a MacMini mid 2011 with macOS 10.13.6, Xcode 10.1. 
>>> This NSWindow API did exist, and the patch could be built without error.
>>> Searching convertPointFromScreen in Xcode.app’s platform SDK showed that it 
>>> was defined at line 440 in NSWindow.h of AppKit.framework.
>>> 
>>> May I ask what build environment did you use (as printed by `xcode-select 
>>> -p`)?
>> 
>> manooth$ xcode-select -p
>> /Applications/Xcode.app/Contents/Developer
>> 
>> But that doesn't seem to be what the C compiler is actually
>> using, because the error messages quote the filename
>> /System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h
>> There is no convertPointFromScreen in that header; but there
>> is one in both of
>> 
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Versions/C/Headers/NSWindow.h
>> 
>> and
>> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Versions/C/Headers/NSWindow.h
>> 
>> which are the other two copies of NSWindow.h this machine has.
>> 
>> thanks
>> -- PMM
> This was really odd.
> 
> I tried to figure out what was wrong with the toolchain and run `xcode-select 
> --install` and `xcode-select --switch`. After the this, clang failed like 
> what you mentioned.
> 
> I had to re-configure qemu with --extra-cflags="-isysroot `xcrun 
> --show-sdk-path`”, forcing clang to use the correct SDK root, and then it 
> would compile.
> 
> Thanks and best regards,