[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode
From: |
Chen Zhang |
Subject: |
Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device |
Date: |
Sat, 6 Apr 2019 11:05:59 +0800 |
ping
http://patchwork.ozlabs.org/patch/1059842/
> On Mar 27, 2019, at 10:00 AM, Chen Zhang <address@hidden> wrote:
>
>
>
>> On Mar 27, 2019, at 12:20 AM, Peter Maydell <address@hidden> wrote:
>>
>> On Thu, 21 Mar 2019 at 07:10, Chen Zhang <address@hidden> wrote:
>>>
>>> In fullscreen mode, the window property of cocoaView may not be the key
>>> window, and the current implementation would not grab mouse in
>>> fullscreen mode after left clicks on relative input devices.
>>>
>>> This patch used isFullscreen value as a short-cirtuit condition for
>>> relative input device grabbing.
>>>
>>> Note that this patch should be tested after applying a previous patch
>>> which fixed event location conversion for relative input devices.
>>>
>>> Signed-off-by: Chen Zhang <address@hidden>
>>
>> Can you explain in more detail when this patch makes a
>> difference, please? (for instance, a set of instructions
>> for reproducing the issue).
>>
>
>> I'm confused, because in the toggleFullScreen method, when
>> we switch to full screen mode (which is the only place where
>> we set isFullscreen to true) we always do a [self grabMouse].
>> So if we get into the event handling function and isFullscreen
>> is true, I think the mouse should already be grabbed. What
>> am I missing ?
> Hi,
>
> In fullscreen mode, when the mouse is un-grabbed by pressing Cmd-Opt-g, it
> would not be re-grabbed by clicks in the view, as the window of the view
> would not be key window by then.
>
> BTW, the Ctrl-Alt-Xs in ui/cocoa.m was confusing in the context. Should they
> be replaced by Cmd-Opt-Xs?
>>
>> thanks
>> -- PMM
>
> Best Regards,
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device,
Chen Zhang <=