[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migratio
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers |
Date: |
Wed, 10 Apr 2019 09:34:19 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Cole Robinson (address@hidden) wrote:
> The only caller that checks the error code is looking for != 0,
> so returning false is incorrect.
>
> Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
>
> Signed-off-by: Cole Robinson <address@hidden>
Thanks, this was in 3.1.0 so isn't a 4.0 regression, so it'll have
to wait for 4.1.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34bcad3807..a3dae4cf02 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
> AioContext *aio_context;
>
> if (migration_is_blocked(errp)) {
> - return false;
> + return ret;
> }
>
> if (!replay_can_snapshot()) {
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK