[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag
From: |
Pankaj Gupta |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag |
Date: |
Wed, 10 Apr 2019 04:38:33 -0400 (EDT) |
>
> On Wed 10-04-19 09:38:23, Pankaj Gupta wrote:
> > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct
> > dax_device *dax_dev)
> > {
> > return false;
> > }
> > +static inline bool dax_synchronous(struct dax_device *dax_dev)
> > +{
> > + return true;
> > +}
>
> Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that
> property of dax device is pretty much undefined and I don't see anything
> needing to call it for !CONFIG_DAX...
You are right. Will remove this.
Thanks for the review.
Best regards,
Pankaj
>
> Honza
> --
> Jan Kara <address@hidden>
> SUSE Labs, CR
>
- Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver, (continued)
Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver, Yuval Shaia, 2019/04/10
[Qemu-devel] [PATCH v5 5/6] ext4: disable map_sync for async flush, Pankaj Gupta, 2019/04/10
[Qemu-devel] [PATCH v5 6/6] xfs: disable map_sync for async flush, Pankaj Gupta, 2019/04/10
[Qemu-devel] [PATCH v5 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/04/10
Re: [Qemu-devel] [PATCH v5 0/6] virtio pmem driver, Arkadiusz MiĆkiewicz, 2019/04/10