[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message |
Date: |
Thu, 11 Apr 2019 17:37:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 11/04/19 16:52, Markus Armbruster wrote:
>> char_pty_open() prints a "char device redirected to PTY_NAME (label
>> LABEL)" message to the current monitor or else to stderr. No other
>> ChardevClass::open() prints anything on success. Drop the message.
>>
>> Cc: "Marc-André Lureau" <address@hidden>
>> Cc: Paolo Bonzini <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Marc-André Lureau <address@hidden>
>> ---
>> chardev/char-pty.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/chardev/char-pty.c b/chardev/char-pty.c
>> index b034332edd..a48d3e5d20 100644
>> --- a/chardev/char-pty.c
>> +++ b/chardev/char-pty.c
>> @@ -211,8 +211,6 @@ static void char_pty_open(Chardev *chr,
>> qemu_set_nonblock(master_fd);
>>
>> chr->filename = g_strdup_printf("pty:%s", pty_name);
>> - error_printf("char device redirected to %s (label %s)\n",
>> - pty_name, chr->label);
>>
>> s = PTY_CHARDEV(chr);
>> s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
>
> The reason for the message is that the char device is completely useless
> until the user knows the /dev/pts/N path[1]. You can get it with "info
> chardev" (aka query-chardev for QMP) but there's an interesting chicken
> and egg problem if the pty is for your monitor...
>
> Paolo
During review of v1, I wrote:
If we should decide the message is still useful enough to be worth
keeping, I could direct it to stdout instead of dropping it.
No clear conclusion emerged, so I did nothing for v2. If we conclude to
keep the message now, I'll gladly do that.
> [1] once you know it, you can use the monitor's readline interface with
> e.g. "socat STDIO,cfmakeraw FILE:/dev/pts/1"
There's also
$ socat UNIX:/path/to/socket
READLINE,history=$HOME/.hmp_history,prompt='(qemu) '
Lacks completion. But then our very own reimplementation of readline
lacks any number of other features.
- [Qemu-devel] [PATCH v2 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), (continued)
- [Qemu-devel] [PATCH v2 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 11/15] monitor error: Make printf()-like functions return a value, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 08/15] vfio: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 02/15] block/ssh: Do not report read/write/flush errors to the user, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 06/15] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message, Markus Armbruster, 2019/04/11
- Re: [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message, Peter Krempa, 2019/04/11
- [Qemu-devel] [PATCH v2 14/15] char: Make -chardev help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 07/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 13/15] blockdev: Make -drive format=help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 15/15] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 14.5/15] char-pty: Print "char device redirected" message to stdout, Markus Armbruster, 2019/04/17