[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 14.5/15] char-pty: Print "char device redirected"
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 14.5/15] char-pty: Print "char device redirected" message to stdout |
Date: |
Wed, 17 Apr 2019 20:11:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr. This is not
an error, so it shouldn't go to stderr. Print it to stdout instead.
Why is it even printed? No other ChardevClass::open() prints anything
on success. It's because you need to know PTY_NAME to actually use
this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME"
to use the monitor's readline interface. You can get PTY_NAME with
"info chardev" (a.k.a. query-chardev for QMP), but only if you already
have a monitor.
Signed-off-by: Markus Armbruster <address@hidden>
---
chardev/char-pty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index b034332edd..4ff2f328fa 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -211,8 +211,8 @@ static void char_pty_open(Chardev *chr,
qemu_set_nonblock(master_fd);
chr->filename = g_strdup_printf("pty:%s", pty_name);
- error_printf("char device redirected to %s (label %s)\n",
- pty_name, chr->label);
+ qemu_printf("char device redirected to %s (label %s)\n",
+ pty_name, chr->label);
s = PTY_CHARDEV(chr);
s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
--
2.17.2
- [Qemu-devel] [PATCH v2 03/15] char-pty: Drop "char device redirected to" message, (continued)
- [Qemu-devel] [PATCH v2 14/15] char: Make -chardev help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 07/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 13/15] blockdev: Make -drive format=help print to stdout, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 15/15] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH v2 14.5/15] char-pty: Print "char device redirected" message to stdout,
Markus Armbruster <=