[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1] hw/input: Add a CONFIG_PS2 switch for t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-4.1] hw/input: Add a CONFIG_PS2 switch for the ps2.c file |
Date: |
Fri, 12 Apr 2019 09:41:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 11/04/19 20:22, Thomas Huth wrote:
> ps2.c only needs to be compiled if we are building pckbd.c or pl050.c.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/input/Kconfig | 5 +++++
> hw/input/Makefile.objs | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index e2e66f0858..316573f782 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -8,10 +8,15 @@ config LM832X
> config PCKBD
> bool
> default y
> + select PS2
> depends on ISA_BUS
>
> config PL050
> bool
> + select PS2
> +
> +config PS2
> + bool
>
> config STELLARIS_INPUT
> bool
> diff --git a/hw/input/Makefile.objs b/hw/input/Makefile.objs
> index c8b00f71ec..6db5ee0e71 100644
> --- a/hw/input/Makefile.objs
> +++ b/hw/input/Makefile.objs
> @@ -3,7 +3,7 @@ common-obj-y += hid.o
> common-obj-$(CONFIG_LM832X) += lm832x.o
> common-obj-$(CONFIG_PCKBD) += pckbd.o
> common-obj-$(CONFIG_PL050) += pl050.o
> -common-obj-y += ps2.o
> +common-obj-$(CONFIG_PS2) += ps2.o
> common-obj-$(CONFIG_STELLARIS_INPUT) += stellaris_input.o
> common-obj-$(CONFIG_TSC2005) += tsc2005.o
>
>
Queued, thanks. (Also, nice find :)).
Paolo