Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

[Paul Durrant]

> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:address@hidden
> Sent: 12 April 2019 17:37
> To: Marc-André Lureau <address@hidden>; address@hidden
> Cc: Markus Armbruster <address@hidden>; Anthony Perard <address@hidden>; Paul 
> Durrant
> <address@hidden>; Stefano Stabellini <address@hidden>; Gerd Hoffmann
> <address@hidden>; Paolo Bonzini <address@hidden>; Philippe Mathieu-Daudé 
> <address@hidden>
> Subject: [PATCH] vl: Add missing descriptions to the VGA adapters list
> 
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
> 
>   $ qemu-system-arm -M virt -vga help
>   none
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb
> 
> Add a description to the missing adapters:
> 
>   $ qemu-system-arm -M virt -vga help
>   none                 no graphic card
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb                Xen paravirtualized framebuffer
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Based-on: <address@hidden>

Reviewed-by: Paul Durrant <address@hidden>

> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
>  static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      [VGA_NONE] = {
>          .opt_name = "none",
> +        .name = "no graphic card",
>      },
>      [VGA_STD] = {
>          .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo 
> vga_interfaces[VGA_TYPE_MAX] = {
>      },
>      [VGA_XENFB] = {
>          .opt_name = "xenfb",
> +        .name = "Xen paravirtualized framebuffer",
>      },
>  };
> 
> --
> 2.20.1