Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list

[Marc-André Lureau]

Hi

On Fri, Apr 12, 2019 at 6:37 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
>   $ qemu-system-arm -M virt -vga help
>   none
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb
>
> Add a description to the missing adapters:
>
>   $ qemu-system-arm -M virt -vga help
>   none                 no graphic card
>   std                  standard VGA
>   cirrus               Cirrus VGA (default)
>   vmware               VMWare SVGA
>   xenfb                Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Based-on: <address@hidden>

nice follow up, thanks
Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
>  static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
>      [VGA_NONE] = {
>          .opt_name = "none",
> +        .name = "no graphic card",
>      },
>      [VGA_STD] = {
>          .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo 
> vga_interfaces[VGA_TYPE_MAX] = {
>      },
>      [VGA_XENFB] = {
>          .opt_name = "xenfb",
> +        .name = "Xen paravirtualized framebuffer",
>      },
>  };
>
> --
> 2.20.1
>
>


-- 
Marc-André Lureau