[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu: Fix crash with empty -cpu option
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH] cpu: Fix crash with empty -cpu option |
Date: |
Thu, 18 Apr 2019 10:09:04 +0200 |
User-agent: |
NeoMutt/20180716 |
On Thu, Apr 18, 2019 at 12:45:01AM -0300, Eduardo Habkost wrote:
> Fix the following crash:
>
> $ qemu-system-x86_64 -cpu ''
> qemu-system-x86_64: qom/cpu.c:291: cpu_class_by_name: \
> Assertion `cpu_model && cc->class_by_name' failed.
>
> Regression test script included.
>
> Fixes: commit 99193d8f2ef5 ("cpu: drop unnecessary NULL check and
> cpu_common_class_by_name()")
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> exec.c | 4 ++++
> tests/acceptance/empty_cpu_model.py | 19 +++++++++++++++++++
> 2 files changed, 23 insertions(+)
> create mode 100644 tests/acceptance/empty_cpu_model.py
>
Reviewed-by: Stefano Garzarella <address@hidden>
Tested-by: Stefano Garzarella <address@hidden>
Thanks,
Stefano