Re: [Qemu-devel] [PATCH] target/mips: Amend tests for MSA binary integer operations

[Mateja Marjanovic]

On 17.4.19. 22:22, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic
> > Subject: Re: [PATCH] target/mips: Amend tests for MSA binary integer operations
> >
> > > From: Mateja Marjanovic <address@hidden>
> > > Subject: [PATCH] target/mips: Amend tests for MSA binary integer operations
> > >
> > > Amend tests for certain MSA binary integer instructions
> > > (for example DIV_S.B) by appending two missing test cases
> > > to complete standard battery of 80 test cases for each
> > > such instruction. Expected values were pulled from the
> > > results of the MIPS64r6 machine that executed those
> > > instruction, and QEMU emulation should produce the same
> > > results.
> > >
> > > Signed-off-by: Mateja Marjanovic <address@hidden>
> > > ---
> > I'm afraid your patch doesn't apply to the tip of the source tree:
> Unfortunately, Mateja, even after resolving patch application conflicts,
> the code doesn't build.
>
> For example, wrappers for many MSA instructions are missing, and
> there are other problems too.
>
> The patch needs a major amending and refactoring, which I will do
> tomorrow, or in next few days, so that you can focus on your other
> remaining tasks (for example, explaining "active_fpu" role from
> another series, and big endian host MSA test failures).

Alright, I will focus on those tasks.

Thanks,
Mateja

> The good thing is that we will eventually expand test coverage.
>
> Thanks,
> Aleksandar