Re: [Qemu-devel] [PATCH v3 02/20] gdbstub: Implement deatch (D pkt) with new infra

[Richard Henderson]

On 4/24/19 7:26 AM, address@hidden wrote:
> +        {
> +            static GdbCmdParseEntry deatch_cmd_desc = {

static const.  s/deatch/detach/.

That'll require changes to patch 1, since process_string_cmd doesn't take a
const GdbCmdParseEntry pointer.

> +                .handler = handle_detach,
> +                .cmd = "D",
> +                .cmd_startswith = 1,
> +                .schema = "?.l0"
> +            };
> +            process_string_cmd(s, NULL, line_buf, &deatch_cmd_desc, 1);

process_string_cmd returns errors, which you make no attempt to handle here.
Should the errors returns in fact be asserts?


r~