qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 20/20] gdbstub: Refactor parse handle packet


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 20/20] gdbstub: Refactor parse handle packet to work with a static array
Date: Wed, 24 Apr 2019 10:28:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 4/24/19 7:27 AM, address@hidden wrote:
> +static GdbCmdParseEntry gdb_packet_table[0x100] = {

21 out of 256 entries used?  That's a pretty poor occupancy rate.
What was wrong with the switch statement?

Or a modified version in which you sink the call to process_string_cmd
and only load the pointer to the structure within the switch.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]